Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu styling #1043

Merged
merged 1 commit into from Jan 6, 2022
Merged

Fix context menu styling #1043

merged 1 commit into from Jan 6, 2022

Conversation

lampsitter
Copy link
Contributor

Closes #1030.

@lampsitter lampsitter marked this pull request as ready for review January 5, 2022 23:30
emilk
emilk reviewed Jan 6, 2022
View reviewed changes
egui/src/menu.rs Outdated
item_spacing: Vec2::ZERO,
button_padding: crate::vec2(2.0, 0.0),
..Default::default()
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should only over-write item_spacing and button_padding and leave the rest of the fields?

Copy link
Contributor Author

@lampsitter lampsitter Jan 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Though button_padding should probably not be hardcoded at all. Would adding a spacing.menu_button_padding be appropriate?

@emilk emilk merged commit b0ea4dc into emilk:master Jan 6, 2022
@lampsitter lampsitter deleted the style-bugfix branch January 6, 2022 11:26
psiphi75 added a commit to psiphi75/egui that referenced this pull request Jan 10, 2022
@psiphi75
Added explicit Event::Paste change
0193b7b 
See emilk#1043
emilk added a commit that referenced this pull request Jan 10, 2022
@psiphi75 @emilk
Split Event::Text into Text and Paste (#1058)
225d2b5 
* Split `Event::Text` into `Text` and `Paste`

* Added explicit Event::Paste change

See #1043

* Link to PR in changelog (not the issue)

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context menu does not follow light theme
2 participants
@lampsitter @emilk