-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shaders on GLSL 1.2 #187
Conversation
- Used `glium::program` to create shaders - Moved shaders code to its own sources and include it as str - Added shaders implementation on GLSL which allows run egui on old hardware (Raspberry Pi 1/zero in game again)
I'm not an expert in GLSL dialects but seems the shader's code from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! Please also add a line to egui_glium/CHANGELOG.md
@katyo did you test both I ask because they seem to be carbon-copied of the WebGL shaders, including statements like "WebGL doesn't come with sRGBA textures" (but does GLES?) and "WebGL doesn't support linear blending in the framebuffer" (but does GLES?). This is particularly relevant since I recently improved the WebGL shaders: effd3c7 |
@emilk Seems the version string is wrong for GLSL ES 1.00 shaders. According to specs it should be |
glium::program
to create shaders(Raspberry Pi 1/zero in game again)
It should solve #79 #80.
Another shader versions (1.1, 1.3, 1.0 ES and etc.) still missing and can be added later.