Improved plot groups and bounds handling #2410
Conversation
|
This allowed me to do some multi-threaded window drawing where I stumbled across a couple of deadlocks. I fixed them here as well, but let me know if you'd prefer a separate PR for that. |
…ounds-improvements
…ounds-improvements
…ounds-improvements
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
…ounds-improvements
|
Thanks for taking the time @emilk. I addressed the comments. It looks like CI is failing, but for a reason unrelated to this PR. |
…ounds-improvements
…ounds-improvements
|
I think this broke something:
|
s-nie
force-pushed
the
plot-groups-and-bounds-improvements
branch
from
fee22a7
to
e39fd37
Compare
…ounds-improvements
…ounds-improvements
…ounds-improvements
…ounds-improvements
| response: Response, | ||
| bounds_modifications: Vec<BoundsModification>, |
There was a problem hiding this comment.
why are you accumulating modifications instead of applying them right away?
There was a problem hiding this comment.
So that they can be applied together at the right time, there are some other transforms that should be done between lines 711 and 763 before the modifications.
I'm sure there are other ways to do this as well, but the bound handling is pretty complex and I didn't want to mess with it too much.
There was a problem hiding this comment.
Can you add it as a comment to the code? 🙏
There was a problem hiding this comment.
Added a comment in eaec082.
|
I made some improvements to the interaction with auto_bounds in a PR on the source repo: s-nie#1 We're in fork-of-a-fork territory here to if there's a better way to handle it than making a PR on the fork's repo, then please let me know! |
Improve interaction with auto_bounds
|
Thanks for the improvement @OmegaJak! I merged it into this branch. |
Closes #2409