Add Grid::with_row_color
#2519
Merged
Add Grid::with_row_color
#2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Feb 8, 2023
emilk
reviewed
Feb 8, 2023
emilk
reviewed
Feb 8, 2023
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Thanks! Apologies for being away for so long. I applied the changes you recommended. Makes sense! |
emilk
requested changes
Mar 29, 2023
|
Looks like you patched the warning? Nice. However, for some reason it still says changes are being requested. Sorry, am I missing something? |
emilk
reviewed
Mar 30, 2023
emilk
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR is sort of a fork from the ideas talked about in #364.
I took inspiration from the comments @emilk provided and made this simple implementation.
This change is a bit of a blocker for my own personal project making use of egui which uses grids a lot.
This could allow for this other related issue to close as well: #2339
I'm still very new to rust so feedback is appreciated. Thanks!