Add ability to hide button backgrounds #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while still having background for sliders, checkboxes, etc
emilk
force-pushed
the
emilk/styling-improvements
branch
from
ca1026c
to
c4b8531
Compare
Wumpf
approved these changes
Jan 24, 2023
Co-authored-by: Andreas Reich <andreas@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR you can turn off background for buttons.
This required a bit of work. We want to be able to turn off background colors for buttons, comboboxes, dragvalues, etc, but keep them for checkbox-boxes, radiobutton-circles, slider-backgrounds, etc. Previously these were all controlled by
WidgetVisuals::bg_fill. Now a newWidgetVisuals::optional_bg_fillWidgetVisuals::weak_bg_fillhas been added, which is used by buttons, comboboxes, dragvalues etc.weak_bg_fillcan be safely set toColor32::TRANSPARENTwithout messing up checkboxes, radiobuttons, sliders, etc.I don't really like the nameI kept the oldoptional_bg_fill, and suggestions are welcome.bg_fillnamed as-is, to avoid breaking to much 3rd party code.Turning off the background on ComboBoxes requires making them tighter, to keep the arrow close to the text, so
Spacing::combo_widthwas added.En example of this style: