Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-winit: Fix window position assertion panic caused by negative window size #2722

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

aevyrie
Copy link
Contributor

@aevyrie aevyrie commented Feb 12, 2023

Closes #2721

@aevyrie aevyrie changed the title Fix window position assertion caused by negative window size Fix window position assertion panic caused by negative window size Feb 12, 2023
@Wumpf Wumpf self-requested a review February 12, 2023 14:07
Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!
Confirmed it working for a crash at the same spot I triggered just yesterday by changing the dpi setting (causing the window to be bigger than the screen apparently)

@emilk emilk changed the title Fix window position assertion panic caused by negative window size egui-winit: Fix window position assertion panic caused by negative window size Feb 12, 2023
@emilk emilk merged commit 95247da into emilk:master Feb 12, 2023
@emilk
Copy link
Owner

emilk commented Feb 12, 2023

Thanks! egui-winit and eframe 0.21.1 have been published

emilk added a commit that referenced this pull request Feb 12, 2023
#2722

The crash could happen if the monitor size or DPI changes between runs
@emilk emilk mentioned this pull request Feb 12, 2023
3 tasks
sidit77 pushed a commit to sidit77/egui-tao that referenced this pull request May 6, 2023
emilk/egui#2722

The crash could happen if the monitor size or DPI changes between runs
fayalalebrun pushed a commit to fayalalebrun/egui_glium that referenced this pull request Nov 7, 2023
emilk/egui#2722

The crash could happen if the monitor size or DPI changes between runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clamp_window_to_sane_position causes panic
3 participants