Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI data() read mutability #2742

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Fix UI data() read mutability #2742

merged 4 commits into from
Mar 29, 2023

Conversation

IS2511
Copy link
Contributor

@IS2511 IS2511 commented Feb 15, 2023

Closes #2741

@emilk
Copy link
Owner

emilk commented Feb 28, 2023

needs cargo fmt

@IS2511 IS2511 marked this pull request as ready for review March 5, 2023 10:51
@IS2511
Copy link
Contributor Author

IS2511 commented Mar 5, 2023

Should be all fixed now.
My bad, didn't notice the suggested change. Kinda gave up trying to run sh/check.sh with it complaining about me missing gdk-3.0.

@emilk emilk merged commit 74d43bf into emilk:master Mar 29, 2023
4 of 5 checks passed
@emilk emilk added bug Something is broken egui labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ui.data() requires mutable borrow to get_temp()?
2 participants
@IS2511 @emilk