Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tracing with log #2928

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Replace tracing with log #2928

merged 3 commits into from
Apr 18, 2023

Conversation

emilk
Copy link
Owner

@emilk emilk commented Apr 18, 2023

Why? Writing backends for log is so much nicer than for tracing, and we don't use any of tracings advanced features anyway.

For native apps:

-    tracing_subscriber::fmt::init();
+    env_logger::init();

For web apps:

-    tracing_wasm::set_as_global_default();
+    eframe::web::WebLogger::init(log::LevelFilter::Debug).ok();

For those of you who use tracing and want to see log events, just use tracing = { version = "0.1", features = ["log"] }

@emilk emilk added eframe Relates to epi and eframe dependencies Pull requests that update a dependency file egui labels Apr 18, 2023
@emilk emilk merged commit 9c9a54c into master Apr 18, 2023
37 checks passed
@emilk emilk deleted the emilk/replace-tracing-with-log branch April 18, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant