Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CollapsingState::remove to clear stored state #3252

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add CollapsingState::remove to clear stored state #3252

merged 2 commits into from
Aug 14, 2023

Conversation

dmackdev
Copy link
Contributor

This PR adds a removal method for CollapsingState to remove its persisted InnerState from memory.

Closes #3250.

@dmackdev dmackdev marked this pull request as ready for review August 13, 2023 23:38
@emilk
Copy link
Owner

emilk commented Aug 14, 2023

I'm not sure why the CI isn't running - can you please try merging in latest master? 🙏

@dmackdev
Copy link
Contributor Author

I'm not sure why the CI isn't running - can you please try merging in latest master? 🙏

@emilk
Done!

@emilk emilk added the egui label Aug 14, 2023
@emilk emilk changed the title Added remove method for CollapsingState. Add CollapsingState::remove to clear stored state Aug 14, 2023
@emilk emilk merged commit 8ee506e into emilk:master Aug 14, 2023
18 of 19 checks passed
@dmackdev dmackdev deleted the add-collapsing-state-removal branch August 14, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "remove" functionality for CollapsingState
2 participants