Support images with rounded corners #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
Image::rounding to support images with rounded corners
abey79
approved these changes
Aug 14, 2023
| /// | ||
| /// To display a texture, set [`Self::fill_texture_id`], | ||
| /// and set this to `Rect::from_min_max(pos2(0.0, 0.0), pos2(1.0, 1.0))`. | ||
| pub uv: Rect, |
There was a problem hiding this comment.
I assume this is to spare the Option on fill_texture_id, and the assorted 1 byte + padding impact on the struct size?
There was a problem hiding this comment.
That, and for symmetry with the backend where the top-left texel of the default texture is always white
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now control the rounding of images using
Image::rounding. This is implemented by augmentingRectShapewith texture support. The corners are anti-aliased.Example output:
