Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved texture loading #3315

Merged
merged 61 commits into from
Sep 12, 2023
Merged

Improved texture loading #3315

merged 61 commits into from
Sep 12, 2023

Conversation

jprochazk
Copy link
Collaborator

@jprochazk jprochazk commented Sep 7, 2023 •
edited
Loading

Part of #3291

@jprochazk jprochazk added egui egui_extras feature New feature or request labels Sep 7, 2023
@jprochazk jprochazk marked this pull request as ready for review September 8, 2023 09:28
emilk
emilk reviewed Sep 11, 2023
View reviewed changes
crates/egui/src/context.rs Outdated Show resolved Hide resolved
crates/egui/src/lib.rs Outdated Show resolved Hide resolved
crates/egui/src/load.rs Outdated Show resolved Hide resolved
crates/egui/src/load.rs Outdated Show resolved Hide resolved
crates/egui/src/load.rs Show resolved Hide resolved
crates/egui_extras/src/loaders/ehttp_loader.rs Outdated Show resolved Hide resolved
examples/images/Cargo.toml Outdated Show resolved Hide resolved
examples/images/README.md Outdated Show resolved Hide resolved
examples/images/src/main.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/image.rs Outdated Show resolved Hide resolved
jprochazk and others added 18 commits September 11, 2023 17:39
@jprochazk
more egui_extras::loaders docs
1a92435
@jprochazk @emilk
Update examples/images/src/main.rs
39ccb15 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@jprochazk
update images example screenshots + readme
0680a2a
@jprochazk
remove unused rfd from images example
e136fa6
@jprochazk @emilk
Update crates/egui_extras/src/loaders/ehttp_loader.rs
400edd0 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@jprochazk
add must_use on Image and RawImage
89c537f
@jprochazk
document loaders::install multiple call safety
cc88beb
@jprochazk @emilk
Update crates/egui_extras/Cargo.toml
f3d5c45 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@jprochazk
reshuffle is_loader_installed
84cda37
@jprochazk
make include_image produce ImageSource + update docs
2bf7716
@jprochazk
update include_image docs
0faf371
@jprochazk
remove None mentions from loader forget
ae202ed
@jprochazk
inline From texture id + size for SizedTexture
e7ad4d8
@jprochazk
add warning about statically known path
6dc60de
@jprochazk
change image load error + use in image button
39b6877
@jprochazk
add .size() to Image
8d6c60f
@jprochazk @emilk
Update crates/egui_demo_app/Cargo.toml
d51f182 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@jprochazk
add explanations to image viewer ui
fa5cb22
@jprochazk
Copy link
Collaborator Author

Okay, the removal of RawImage can be left to a different PR. This one is already way too big in scope

@emilk emilk merged commit 2bc6814 into master Sep 12, 2023
34 checks passed
@emilk emilk deleted the texture-loading-p2 branch September 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
egui_extras egui feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jprochazk @emilk