egui: fix scroll not sticking when scrollbar is hidden #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
egui used to completely skip the stick calculation when the scrollbars were not visible, which is incorrect.
|
on second thought and some testing, this is fine actually. This fix should be OK as implemented |
LoganDark
changed the title
emilk
approved these changes
Nov 10, 2023
This comment was marked as resolved.
This comment was marked as resolved.
LoganDark
force-pushed
the
stick-to-end-fix
branch
from
d76785e
to
bbcd93b
Compare
|
There, fixed that up for you. And welcome back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Recording.2023-10-02.221145.mp4
Recording.2023-10-02.221239.mp4
After:
Recording.2023-10-02.222454.mp4