Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming: constraint_to -> constrain_to #3438

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix naming: constraint_to -> constrain_to #3438

merged 1 commit into from
Nov 10, 2023

Conversation

rinde
Copy link
Contributor

@rinde rinde commented Oct 6, 2023

The changelog for 0.23.0 mentioned:

  • Add Area::constrain_to and Window::constrain_to #3396

However, the implementation for Window was called constraint_to (notice the extra 't'). I noticed this because the deprecated message points to the non-existing constrain_to.

emilk
emilk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk added the egui label Nov 10, 2023
@emilk emilk merged commit c0b14f4 into emilk:master Nov 10, 2023
7 of 19 checks passed
@emilk emilk changed the title Fix inconsistent naming of constrain_to versus constraint_to Fix naming: constraint_to -> constrain_to Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rinde @emilk