Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eframe: Fix window flashing white on launch #3631

Merged
merged 2 commits into from Nov 27, 2023

Conversation

zeozeozeo
Copy link
Contributor

This is a bug that can occur on Windows, previously it was fixed by only showing the window after the first frame was rendered, but the bug appeared again with egui 0.24.0. This commit fixes this bug by making the window invisible on startup.

Before

window-flash

After

no-window-flash

Closes #3625.

This is a bug that can occur on Windows, previously it was fixed by only
showing the window after the first frame was rendered, but the bug
appeared again with egui 0.24.0. This commit fixes this bug by making
the window invisible on startup.
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

crates/eframe/src/native/glow_integration.rs Outdated Show resolved Hide resolved
crates/eframe/src/native/wgpu_integration.rs Outdated Show resolved Hide resolved
@emilk emilk added bug Something is broken eframe Relates to epi and eframe native-windows Running on native Windows OS labels Nov 27, 2023
@emilk emilk merged commit 4dc964a into emilk:master Nov 27, 2023
21 of 22 checks passed
@zeozeozeo zeozeozeo deleted the no-window-flash branch November 27, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken eframe Relates to epi and eframe native-windows Running on native Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window flashes white on launch on Windows
2 participants