Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi-viewports across monitors with different scales #3663

Merged
merged 6 commits into from Nov 30, 2023

Conversation

emilk
Copy link
Owner

@emilk emilk commented Nov 30, 2023

It required some ugly code in egui-winit in order to fix this without breaking sem-ver (I want this to land in a 0.24.1 patch release). I'll clean up in time for 0.25.

There is still a font rendering bug when using immediate viewports across multiple viewports, but that's harder to fix.

@emilk emilk added bug Something is broken eframe Relates to epi and eframe viewports multiple viewports, viewports API labels Nov 30, 2023
@emilk emilk marked this pull request as draft November 30, 2023 09:17
@emilk emilk changed the title Fix multi-viewport bugs across monitors with different scales Fix multi-viewport sizes across monitors with different scales Nov 30, 2023
@emilk emilk marked this pull request as ready for review November 30, 2023 10:54
@emilk emilk changed the title Fix multi-viewport sizes across monitors with different scales Improve multi-viewports across monitors with different scales Nov 30, 2023
@emilk emilk merged commit 61a7b90 into master Nov 30, 2023
35 checks passed
@emilk emilk deleted the emilk/multi-viewport-fixes branch November 30, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken eframe Relates to epi and eframe viewports multiple viewports, viewports API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant