eframe glow backend: Clear framebuffer color before calling App::update
#3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
emilk
commented
Nov 30, 2023
emilk
commented
- Closes Order of clearing and painting change in 0.24? #3659
emilk
changed the title
App::updateApp::update
emilk
added a commit
that referenced
this pull request
Dec 18, 2023
I broke this in #3665 For some reason, when using multiple viewports, the first "clear" doesn't take. I don't have time to investigate further, so I am adding a hack here which: * For single-viewport apps, the clear is done before `App::update` so user can paint there * For multi-viewport apps, the clear is done after `App::update`, so that it works This means painting in `App::update` won't work with multi-viewports. Ideally, users should use paint callbacks instead of painting directly in `App::update` anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.