TextEdit: Change margin property to egui::Margin type
#3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al `Margin` struct for consistency and to support asymmetric margins.
…xtedit-margin-property-to-margin-struct # Conflicts: # crates/egui/src/widgets/text_edit/builder.rs
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
changed the title
margin property to egui::Margin typeTextEdit: Change margin property to egui::Margin type
emilk
approved these changes
Feb 10, 2024
|
The code doesn't compile yet :) |
…xtedit-margin-property-to-margin-struct # Conflicts: # crates/egui/src/widgets/text_edit/builder.rs
emilk
approved these changes
Feb 11, 2024
emilk
reviewed
Feb 12, 2024
emilk
approved these changes
Feb 12, 2024
bu5hm4nn
deleted the
feature/change-textedit-margin-property-to-margin-struct
branch
bu5hm4nn
added a commit
to bu5hm4nn/egui
that referenced
this pull request
Feb 15, 2024
Despite their being an actual `egui::Margin` struct, Textedit has a `margin()` builder function that supports only `Vec2` types and thereby only symmetric margins. This PR changes the function to accept `egui::Margin` type instead making it more congruent with overall egui logic as well as supporting asymmetric margins. P.S: I tried to run all checks but I had to modify `./rust-toolchain` to 1.67.0 to get the checks to run on macOS. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
bu5hm4nn
added a commit
to bu5hm4nn/egui
that referenced
this pull request
Feb 15, 2024
Despite their being an actual `egui::Margin` struct, Textedit has a `margin()` builder function that supports only `Vec2` types and thereby only symmetric margins. This PR changes the function to accept `egui::Margin` type instead making it more congruent with overall egui logic as well as supporting asymmetric margins. P.S: I tried to run all checks but I had to modify `./rust-toolchain` to 1.67.0 to get the checks to run on macOS. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
bu5hm4nn
added a commit
to bu5hm4nn/egui
that referenced
this pull request
Mar 8, 2024
Despite their being an actual `egui::Margin` struct, Textedit has a `margin()` builder function that supports only `Vec2` types and thereby only symmetric margins. This PR changes the function to accept `egui::Margin` type instead making it more congruent with overall egui logic as well as supporting asymmetric margins. P.S: I tried to run all checks but I had to modify `./rust-toolchain` to 1.67.0 to get the checks to run on macOS. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite their being an actual
egui::Marginstruct, Textedit has amargin()builder function that supports onlyVec2types and thereby only symmetric margins. This PR changes the function to acceptegui::Margintype instead making it more congruent with overall egui logic as well as supporting asymmetric margins.P.S: I tried to run all checks but I had to modify
./rust-toolchainto 1.67.0 to get the checks to run on macOS.