egui_glow: Only disable sRGB framebuffer on supported platforms #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emilk
changed the title
This solves a GL_INVALID_ENUM error common on Windows, see servo/servo#30782.
Nopey
force-pushed
the
fix-srgb-glerror
branch
from
e85b7c3
to
0bb598d
Compare
emilk
pushed a commit
that referenced
this pull request
Feb 10, 2024
This solves a GL_INVALID_ENUM error common on Windows (occurs on my Windows 10 machine with a GTX 1070 Ti). <!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> ARB_framebuffer_SRGB is entirely unsupported on WebGL, hence why latest egui (master branch) doesn't try to disable SRGB framebuffers on wasm32 and this PR's code doesn't even check for ARB_framebuffer_sRGB on wasm32. * For <servo/servo#30782>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a GL_INVALID_ENUM error common on Windows (occurs on my Windows 10 machine with a GTX 1070 Ti).
ARB_framebuffer_SRGB is entirely unsupported on WebGL, hence why latest egui (master branch) doesn't try to disable SRGB framebuffers on wasm32 and this PR's code doesn't even check for ARB_framebuffer_sRGB on wasm32.