Fix TextEdit being too short whenever there is horizontal margin
#4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
TextEdit being too short whenever there is horizontal margin
emilk
pushed a commit
that referenced
this pull request
Feb 10, 2024
…4005) The allocated width is reduced by the horizontal margin inside `show_content` but the margin is already factored into the content_ui's rect. This causes both text and frame (not shown here) to be `2.0 * margin.x` too short. Before:  After:  (*The blue rect is the TextEdit's (expected) final size.) Co-authored-by: Georg Weisert <georg.weisert@freshx.de>
bu5hm4nn
pushed a commit
to bu5hm4nn/egui
that referenced
this pull request
Feb 15, 2024
…milk#4005) The allocated width is reduced by the horizontal margin inside `show_content` but the margin is already factored into the content_ui's rect. This causes both text and frame (not shown here) to be `2.0 * margin.x` too short. Before:  After:  (*The blue rect is the TextEdit's (expected) final size.) Co-authored-by: Georg Weisert <georg.weisert@freshx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allocated width is reduced by the horizontal margin inside
show_contentbut the margin is already factored into the content_ui's rect.This causes both text and frame (not shown here) to be
2.0 * margin.xtoo short.Before:
After:
(*The blue rect is the TextEdit's (expected) final size.)