Update memoffset to 0.9.0, arboard to 3.3.1, and remove egui_glow's needless dependency on pure_glow's deps #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emilk
approved these changes
Feb 13, 2024
emilk
added
egui_glow
varphone
added a commit
to varphone/egui
that referenced
this pull request
Feb 13, 2024
emilk
pushed a commit
that referenced
this pull request
Feb 13, 2024
…4037) After merging PR #4036, build errors occurred in eframe-related applications: ```log error[E0432]: unresolved import `winapi::um::winuser` --> crates\eframe\src\native\app_icon.rs:83:9 | 83 | use winapi::um::winuser; | ^^^^^^^^^^^^^^^^^^^ no `winuser` in `um` | note: found an item that was configured out --> C:\Users\Varphone\.cargo\registry\src\index.crates.io-6f17d22bba15001f\winapi-0.3.9\src\um\mod.rs:290:37 | 290 | #[cfg(feature = "winuser")] pub mod winuser; | ^^^^^^^ = note: the item is gated behind the `winuser` feature For more information about this error, try `rustc --explain E0432`. error: could not compile `eframe` (lib) due to previous error warning: build failed, waiting for other jobs to finish... ```
emilk
pushed a commit
that referenced
this pull request
Feb 14, 2024
…eedless dependency on pure_glow's deps (#4036) <!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR. * Remember to run `cargo fmt` and `cargo cranky`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> These are the latest versions of memoffset and arboard. The changes to egui_glow/pure_glow allow downstream crates to not depend on rwh 0.5, which is only needed for pure_glow (and other projects that use glutin) Thanks for your time & work
emilk
pushed a commit
that referenced
this pull request
Feb 14, 2024
…4037) After merging PR #4036, build errors occurred in eframe-related applications: ```log error[E0432]: unresolved import `winapi::um::winuser` --> crates\eframe\src\native\app_icon.rs:83:9 | 83 | use winapi::um::winuser; | ^^^^^^^^^^^^^^^^^^^ no `winuser` in `um` | note: found an item that was configured out --> C:\Users\Varphone\.cargo\registry\src\index.crates.io-6f17d22bba15001f\winapi-0.3.9\src\um\mod.rs:290:37 | 290 | #[cfg(feature = "winuser")] pub mod winuser; | ^^^^^^^ = note: the item is gated behind the `winuser` feature For more information about this error, try `rustc --explain E0432`. error: could not compile `eframe` (lib) due to previous error warning: build failed, waiting for other jobs to finish... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the latest versions of memoffset and arboard.
The changes to egui_glow/pure_glow allow downstream crates to not depend on rwh 0.5, which is only needed for pure_glow (and other projects that use glutin)
Thanks for your time & work