Disable glow scissor test after painting #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexApps99
reviewed
Nov 20, 2021
egui_glow/src/painter.rs
Outdated
| gl.viewport(0, 0, width_in_pixels as i32, height_in_pixels as i32); | ||
|
|
||
| // gl.viewport(0, 0, width_in_pixels as i32, height_in_pixels as i32); | ||
| // gl.viewport(0, 0, 300, 300); |
There was a problem hiding this comment.
Why is glViewport commented out? Does it affect something adversely?
| @@ -37,6 +37,8 @@ fn create_display( | |||
| } | |||
|
|
|||
| fn main() { | |||
| let mut clear_color = [0.1, 0.1, 0.1]; | |||
There was a problem hiding this comment.
Is there any reason for changing this?
|
Thanks for reviewing this @AlexApps99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR solved the issue better described in #904
basically if you don't disable the scissor test after drawing all the ui, the framebuffer goes bananas.