Update composer.json to allow newer version of league/geotools #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Offlein. Thank you for your contribution. Given that this package has not received much care for a while, I am happy to merge the change in case it will help others. I do have reservations about allowing all major versions of a dependency, however that can be addressed when refining the package for version 1.0. As my time is limited at the moment, I very much appreciate any contributions that help the package stay up to date. Cheers! |
|
Hi @emilklindt Yes, me too. :( I guess it'd be "great" if it became a problem on the other hand, because then people are using it and engaging with it, too? That's one way to look at it, at least. Anyway, thank you for this package. It's really helping me out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your package seems to work with newer versions of Laravel, but cannot install right now because
league/geotools:0.8.3explicitly requires older versions ofsymfony/console.If you allow newer league/geotools, things seem to work fine and we can use this in newer Laravel.