types: change label types to ReactNode

[CanRau]

Just started using sonner and realized action.label & cancel.label could accept ReactNode instead of string so you can pass in a more complex custom label including an icon or whatever.

Hope you agree, if not I'd be curious of possible downsides I might not've considered and can be closed.

Closes: #273

Also just saw that cancel.onClick is typed onClick?: () => void; while action.onclick = onClick: (event: React.MouseEvent<HTMLButtonElement>) => void; is there a reason or should I open another PR to add the event to cancel.onClick as well?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sonner	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 30, 2023 2:57pm

[emilkowalski]

Just started using sonner and realized action.label & cancel.label could accept ReactNode instead of string so you can pass in a more complex custom label including an icon or whatever.

Hope you agree, if not I'd be curious of possible downsides I might not've considered and can be closed.

Closes: #273

Also just saw that cancel.onClick is typed onClick?: () => void; while action.onclick = onClick: (event: React.MouseEvent<HTMLButtonElement>) => void; is there a reason or should I open another PR to add the event to cancel.onClick as well?

Thank you! You can change the onClick types in this PR if you want to!

[emilkowalski]

Hmm... looks like there is a build error

[CanRau]

I think this might be fixed now after I actually passed the event to cancel.onClick ?

[emilkowalski]

Got some TS errors

[CanRau]

😳 oops I'm sorry, should be fixed now, forgot to add the argument to the button's event handler, that happens when making PRs on GitHub 😅