-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Types): adds warning type toast #39
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @emilkowalski on Vercel. @emilkowalski first needs to authorize it. |
@emilkowalski have you by any chance had a chance to look at this? :) |
@JayWelsh This is awesome! Could we change the colors to these? Also, I would love to swap the icon for the warning solid icon from https://heroicons.com/ Light: Dark: |
Thanks a lot @emilkowalski ! I've made the requested adjustments 👍 |
This looks great |
Hi @emilkowalski, Is there anything I can do with this to make it more likely to be merged? Kindest Regards, |
Try to merge the base branch into your branch: |
Thanks, done 👍 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
After much consideration I decided to stick with the types we currently have. I appreciate your work a lot tho! |
Hmm @emilkowalski , I know you're unlikely to change your mind but if you just Google image search "toast types web dev" pretty much every example shows an info type (default in the case of sonner), success, error, warning. In my opinion, it's a strangely missing feature to have the warning type left out, and I think it would increase this library's adoption to have it. It's a totally standard type to have in a toast lib so I'm not sure why there's aversion. But anyway just wanted to mention that, it's of course your choice. |
Adds a new toast type of "warning"
I think it helps to differentiate between success, error and warning type toasts, and since I love this library and wanted to use a warning type, I thought I'd just add it here and create a PR in case you feel the same.
If you would prefer not to have a "warning" type toast, no problem.
Thanks!