Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Types): adds warning type toast #39

Closed
wants to merge 5 commits into from

Conversation

JayWelsh
Copy link

Adds a new toast type of "warning"

Screenshot 2023-03-14 at 11 27 54

I think it helps to differentiate between success, error and warning type toasts, and since I love this library and wanted to use a warning type, I thought I'd just add it here and create a PR in case you feel the same.

If you would prefer not to have a "warning" type toast, no problem.

Thanks!

@vercel
Copy link

vercel bot commented Mar 14, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @emilkowalski on Vercel.

@emilkowalski first needs to authorize it.

@JayWelsh
Copy link
Author

@emilkowalski have you by any chance had a chance to look at this? :)

@emilkowalski
Copy link
Owner

@JayWelsh This is awesome!

Could we change the colors to these? Also, I would love to swap the icon for the warning solid icon from https://heroicons.com/

Light:
background: hsl(49, 100%, 96%)
text: hsl(22, 100%, 40%)
border: hsl(48, 100%, 88%)

Dark:
background: hsl(19, 86%, 8%)
text: hsl(48, 100%, 74%)
border: hsl(23, 100%, 14%),

@JayWelsh
Copy link
Author

Thanks a lot @emilkowalski ! I've made the requested adjustments 👍

@fraserdale
Copy link

This looks great

@JayWelsh
Copy link
Author

JayWelsh commented Apr 17, 2023

Hi @emilkowalski,

Is there anything I can do with this to make it more likely to be merged?

Kindest Regards,
Jay

@owieth
Copy link
Contributor

owieth commented Apr 27, 2023

Hi @emilkowalski,

Is there anything I can do with this to make it more likely to be merged?

Kindest Regards, Jay

Try to merge the base branch into your branch:
This branch is out-of-date with the base branch

@JayWelsh
Copy link
Author

JayWelsh commented Apr 27, 2023

Hi @emilkowalski,
Is there anything I can do with this to make it more likely to be merged?
Kindest Regards, Jay

Try to merge the base branch into your branch: This branch is out-of-date with the base branch

Thanks, done 👍

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 1:58am

@emilkowalski
Copy link
Owner

After much consideration I decided to stick with the types we currently have. I appreciate your work a lot tho!

@JayWelsh
Copy link
Author

JayWelsh commented May 23, 2023

Hmm @emilkowalski , I know you're unlikely to change your mind but if you just Google image search "toast types web dev" pretty much every example shows an info type (default in the case of sonner), success, error, warning.

In my opinion, it's a strangely missing feature to have the warning type left out, and I think it would increase this library's adoption to have it. It's a totally standard type to have in a toast lib so I'm not sure why there's aversion.

But anyway just wanted to mention that, it's of course your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants