Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-modal drawer closes upon clicking a button outside of drawer #114

Closed
averybiskup opened this issue Sep 22, 2023 · 3 comments
Closed

Comments

@averybiskup
Copy link

Non-modal drawer was fixed recently, but it looks like clicking on a button that is outside of the drawer still closes it. I tried to use stopPropagation() and preventDefault() on the drawer to no avail.

Thanks, Emil!

@emilkowalski
Copy link
Owner

emilkowalski commented Sep 22, 2023

I haven't pushed a new version to npm, will do during the weekend, it should be fixed then.

@averybiskup
Copy link
Author

I had actually cloned this repo, and hosted it locally to test it, and that's when I noticed that buttons still cause it to close.

I'll wait until you update npm to test again, though.

Thanks

@artemis-prime
Copy link
Contributor

Please reopen. This is still in issue Apr 2024. And I have a fix PR brewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants