New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawer with modal=false still closes inappropriately #331

Closed

artemis-prime opened this issue Apr 24, 2024 · 0 comments · Fixed by #332

Contributor

artemis-prime commented Apr 24, 2024 •

edited

Loading

Though #109 fixed the closing issue for general mouse clicks, it did not extend the fix to two other cases:

When the user clicks on a focusable element (button, input, etc)
When the user presses the ESC key.

Both of these still close the drawer, even if modal=false

This is specifically referenced in #37, and #114
This may also affect #184 and others

I'm attaching a PR to this.

artemis-prime mentioned this issue

Fix inappropriate non-modal drawer closure #332

Merged

emilkowalski closed this as completed in #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment