Fix: Prevent sheet from exceeding boundaries of the last snap point while dragging #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erisleci is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
|
So to clarify - if you release the drag it will go back to the latest snap point? |
yeah, onRelease is fine, even if we exceed the boundaries of the last snap point (while dragging) as soon as we release it gets back to closest snap point. onDrag on the other hand can get out of boundaries (upwards) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug I noticed that lets the drawer exceed the snap points boundaries. You can reproduce this by dragging down and as soon as the animation starts, switch to dragging up (without releasing). Is there any use case where this might be needed? If so maybe we can introduce a prop. Let me know
Sandbox: https://codesandbox.io/p/devbox/drawer-snap-points-forked-3xxclj?file=%2Fapp%2Fmy-drawer.tsx
Video: https://www.loom.com/share/db36353318114dedb964d320be8849fc?sid=05234bb7-f938-4666-aba4-b57bd1e993ae