Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Non-Dismissable Swiping #276

Conversation

keeganpotgieter
Copy link
Contributor

Fix a UI issue where the user is unable to drag the drawer in the open direction—up is the default, for example—when the first snap point is active. The fix ensures the user cannot drag beyond the first snap point on close, but can drag open smoothly. It also removes the issue/bug where the user can drag beyond the first snap point when another snap point is active.

Examples

Before Fix

After Fix

Example Drawer.Root props

<Drawer.Root dismissible={false} snapPoints={[0.2, 1]} modal={false}>
    ...
</Drawer.Root>

Copy link

vercel bot commented Feb 19, 2024

@keeganpotgieter is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

@keeganpotgieter keeganpotgieter changed the title Added direction check and new conditioning to ensure a user cannot sw… Fix Non-Dismissable Swiping Feb 19, 2024
@emilkowalski emilkowalski merged commit c2588f0 into emilkowalski:main Feb 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants