fix: block swipe if in wrong direction #314
Merged
+887
−1,368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaom00 is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
joaom00
changed the title
|
@emilkowalski I see this is merged to main, but not deployed to npm. Right now this is blocking people in my production app using vaul from copying text. Do I need to fork vaul and deploy it myself, or is a release right around the corner? |
|
@emilkowalski I'll be fine with a canary/beta release candidate so I can use it before you deploy a minor/patch release |
|
Any scheduled date set for this to be deployed to npm? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
This PR blocks the swipe if the user starts swiping in the wrong direction allowing the user to select text within the vaul. Unfortunately this fix will only work for pointers. It was not possible to fix it for mobile because I realized that the problem comes from the
react-remove-scrolllib that Radix uses under the hood to block scrolling.Also forwards some events from the
DialogPrimitive.ContentpropsBefore
vaul-before.mp4
After
vaul-after.mp4