Some fixes using with callbacks #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brugnara
commented
Sep 15, 2014
brugnara
commented
- Catched error if trying to open a non existent modem that causes exception trying to close a non opened port.
- calling callback(error) on errors.
- null pointer exception
Call callback if exists and on error!
fix null pointer exception.
| @@ -102,12 +102,15 @@ var createModem = function() { | |||
|
|
|||
| modem.port.on('error', function() { | |||
| modem.close(); | |||
| callback && callback(new Error('Serial port error')); | |||
There was a problem hiding this comment.
@brugnara Sure, I will merge the pull request, just, please change the Error to string and I'll just merge it.
There was a problem hiding this comment.
@emilsedgh done. I think we should talk a bit and do a branch where we can do a huge refactor fixing what we said tomorrow. 👍
There was a problem hiding this comment.
@brugnara My email address is emilsedgh@kde.org
You can also find me on IRC, I'm emilsedgh on Freenode and I usually hang out on #Node.js
returning string instead of error
changed returning error string
Fixed timeout on commands
Refixed throw
|
I've closed this issue because of the number of fixes that this module needs. It is very unstable and it is not usable on production on current state. I've rewritten a new one, called node-modem that fully works with callbacks, handling errors and timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.