If list position is retained on rotation header get unstuck

[akshaydashrath]

If I store the position of the listview in saved instance state and then rotate and set selection of the listview the header is back to the top of the list and scrolls with the list, the issue is fixed if I scroll back upt to the top of the list and then rotate.

[rciovati]

I'm able to save the list position and restore it after screen rotation, so it works fine for me.
Can you provide some demo code?

[akshaydashrath]

Sure, I save list position like this:

@OverRide
public void onScroll(AbsListView view, int firstVisibleItem, int visibleItemCount, int totalItemCount) {
this.firstVisible = firstVisibleItem;
}

@OverRide
public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);
outState.putInt(KEY_LIST_POSITION, firstVisible);
}

@OverRide
public void onActivityCreated(Bundle savedInstanceState) {
super.onActivityCreated(savedInstanceState);
getListView().setOnScrollListener(this);
if (savedInstanceState != null) {
firstVisible = savedInstanceState.getInt(KEY_LIST_POSITION);
}
}

private void renewListPosition() {
getListView().setSelection(firstVisible);
}

@Override
public void setListAdapter(ListAdapter adapter) {
    super.setListAdapter(adapter);
    if (adapter != null) {
        renewListPosition();
    }
}

[rciovati]

I use getListView().getFirstVisiblePosition() for save and getListView().setSelectionFromTop() for restore and it works.

[akshaydashrath]

The problem is do that in onSavedInstanceState when using fragments using the compatibility library is the onSavedInstanceState is called after onPause which gives you a content view not created error

[emilsjolander]

on what version of android are you seeing this?

[akshaydashrath]

4.1.1

[emilsjolander]

I just want to clarify the issue, when setting the selection after rotation, the headers are no longer sticky?

[akshaydashrath]

Yes that is correct, Ive moved to say position 15 and the header is now back to the top of the list, adding some logs I notice that the header on rotation is now null

[emilsjolander]

And you have the list inside a support fragment? Anything more i need to know? Setting up a test project now to try to replicate this

[akshaydashrath]

Nope thats about it.

[emilsjolander]

ok, so i tried but it seems to be working just fine. Could you maybe zip up a test project where you are seeing this problem and send it to me so i could take a look?

[akshaydashrath]

Another thing is I'm using a cursor loader to set the adapter, I'll send some code over to you.

[akshaydashrath]

Its very strange, I modified the example app to use the same code I'm using in the project, but the issue cant be reproduced, I'm going to test it a bit more, and if I cant reproduce it Ill close the issue.

[emilsjolander]

sounds good :)

[akshaydashrath]

If a list has only a single header on the page this issue seems to occur, if theres more than a single header its fine

[emilsjolander]

I just tried this with only a single header and still not seeing it. I think i will need a zipped test project where this issue is present.

[androidmoney]

Well, I cannot provide one as it doesn't happen on my phone. But it's easy to see by looking at your code that if you get 2 pushes without a pull, you will pull the wrong item of the cache. It's been a long time, but your code seems to assume that you will get a push and a pull paired.

[emilsjolander]

Many things have been remade since this issue was posted and i have never been able to reproduce it so i am closing it. Please submit another issue if you still see this with the newest version