Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate the global options for customizing MTBSeq #9

Closed
abhi18av opened this issue Jul 9, 2021 · 4 comments · Fixed by #17
Closed

Accomodate the global options for customizing MTBSeq #9

abhi18av opened this issue Jul 9, 2021 · 4 comments · Fixed by #17

Comments

@abhi18av
Copy link
Member

abhi18av commented Jul 9, 2021

These were mentioned here
#8 (comment)

@Mxrcon , reading the codebase for the current PR, I'm not sure if we have made use of these features at all.

This means that for example, any user would only be able to run MTBSeq with the bundled reference fasta file since

Similarly, the absence of --basecalib takes care of the base call calibration

The calibration list is stored in the directory "var/res/MTB_Base_Calibration_List.vcf" of the package. For other reference genomes, the file needs to be specified with the --basecalib OPTION or this step will be skipped.

Basically, the actual design challenge of this workflow is not the DSL2 modules etc, but the treatment of parameters. This is where you need to use creativity and experience 😉

@abhi18av
Copy link
Member Author

abhi18av commented Jul 9, 2021

I'd be happy to connect and discuss the overall design for this.

@Mxrcon
Copy link
Member

Mxrcon commented Jul 9, 2021

yes, sure let's discuss that

@abhi18av
Copy link
Member Author

As mentioned in the #8 (comment) there's one more workflow remaining for the stubs i.e. the tbfull workflow.

For this one, you can accomodate all the options as params and then we can start discussing how to accomodate those a module level since not all the parameters apply to all modules.

@Mxrcon
Copy link
Member

Mxrcon commented Jul 20, 2021

Tasks:

  • Populate the pipeline with standard parameters
  • Add global options to the pipeline

@Mxrcon Mxrcon linked a pull request Jul 20, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants