Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4.5 No tab render #156

Closed
julianpoma opened this issue Jul 12, 2021 · 11 comments
Closed

Version 1.4.5 No tab render #156

julianpoma opened this issue Jul 12, 2021 · 11 comments
Assignees

Comments

@julianpoma
Copy link

After update to 1.4.5 the tabs dissapear. Downgrade to 1.4.4 and clear cache in browser the tabs render OK.

@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

Agh I must have messed something up in the production build. Sorry about that. I’ll make a fix as soon as I can.

I’ll pin this issue for now.

@RVxLab RVxLab pinned this issue Jul 12, 2021
@RVxLab RVxLab self-assigned this Jul 12, 2021
@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

Really odd. The tab on edit works fine but on the details page it's not showing up. No console errors.

@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

Had a further look but I can't seem to find a clear cause. When I build Nova for development or production by hand it works fine. It might be something with the build process but I don't know at this time.

Keep downgraded to 1.4.4 for now. I'll need to take a look later.

@RVxLab RVxLab added the help wanted Extra attention is needed label Jul 12, 2021
@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

My observations so far:

  • The tab component is mounting
  • The root div is rendered
  • The rest of the template is not being rendered

@mstaack
Copy link

mstaack commented Jul 12, 2021

Same here, latest 1.4.5 version shows no tabs anymore

@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

Same here, latest 1.4.5 version shows no tabs anymore

Downgrade to 1.4.4 for now.

@RVxLab
Copy link
Collaborator

RVxLab commented Jul 12, 2021

I released 1.4.6 to address this issue, upgrade to that.

Until a future release the changes introduced with #155 won't be available.

@RVxLab RVxLab closed this as completed Jul 12, 2021
@RVxLab RVxLab unpinned this issue Jul 12, 2021
@RVxLab RVxLab removed the help wanted Extra attention is needed label Jul 12, 2021
@ThaDaVos
Copy link

ThaDaVos commented Apr 8, 2022

Seems to be broken on 1.5.x again - downgraded to 1.4.6

@RVxLab
Copy link
Collaborator

RVxLab commented Apr 8, 2022

See #172

@ThaDaVos
Copy link

ThaDaVos commented Apr 8, 2022

Yeah that's whats happening - weird that I couldn't find that issue

@RVxLab
Copy link
Collaborator

RVxLab commented Apr 8, 2022

I honestly have no idea what's causing this, I'm thinking it's a Nova issue that's outside of my control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants