Added Dusk Selector(s) to FormTab & DetailTabs #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR! Do you reckon you could add it to |
|
Actually didn't thought about it, but it would make sense indeed 😁 I can add it as well, if you like 👌 |
|
That’d be great! |
swatty007
changed the title
|
Yeah & makes much more sense than the halfway implementation😉 I updated the PR accordingly. |
|
Thanks again! 👍🏻 |
|
I have to thank you for the package 😎 |
|
It's actually not my package, I just help maintain it. 👍🏻 |
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dusks selector property to the FormTab component to make Tabs easier test-able with Laravel Dusk to avoid that changing CSS selectors cause broken tests.
The selector uses a slug of the tab name suffixed with the "-tab" string to avoid name conflicts with other components.