Fix in ArrayList.Contains function against nil values

emirpasic · Apr 18, 2022 · b486cc9 · b486cc9
1 parent e635246
commit b486cc9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lists/arraylist/arraylist.go b/lists/arraylist/arraylist.go
@@ -82,8 +82,8 @@ func (list *List) Contains(values ...interface{}) bool {
 
 	for _, searchValue := range values {
 		found := false
-		for _, element := range list.elements {
-			if element == searchValue {
+		for index := 0; index < list.size; index++ {
+			if list.elements[index] == searchValue {
 				found = true
 				break
 			}

diff --git a/lists/arraylist/arraylist_test.go b/lists/arraylist/arraylist_test.go
@@ -164,6 +164,9 @@ func TestListContains(t *testing.T) {
 	if actualValue := list.Contains("a"); actualValue != true {
 		t.Errorf("Got %v expected %v", actualValue, true)
 	}
+	if actualValue := list.Contains(nil); actualValue != false {
+		t.Errorf("Got %v expected %v", actualValue, false)
+	}
 	if actualValue := list.Contains("a", "b", "c"); actualValue != true {
 		t.Errorf("Got %v expected %v", actualValue, true)
 	}