Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please do not overwrite Host header when passing request to Extauth Module #154

Closed
plombardi89 opened this issue Nov 17, 2017 · 1 comment
Closed

Please do not overwrite Host header when passing request to Extauth Module #154

plombardi89 opened this issue Nov 17, 2017 · 1 comment

Comments

@plombardi89
Copy link
Contributor

Currently Ambassador overwrites the incoming Host header on an HTTP request that it is forwarding through the Authentication service.

This is problematic for a number of reasons:

  1. If your Extauth module wants to white list based on Host then it's currently impossible.
  2. If you're doing some kind of tenancy validation (e.g. Host: t-99275365.example.org) matches the the principal of a say an incoming API Key or JWT.
@kflynn
Copy link
Member

kflynn commented Nov 22, 2017

Fixed in 0.18.

@kflynn kflynn closed this as completed Nov 22, 2017
LukeShu added a commit that referenced this issue Sep 6, 2019
@LukeShu
Merge pull request #154 from datawire/lukeshu/readme
5363566 
README: Proof-read, remove obsolete parts
rhs added a commit that referenced this issue Oct 9, 2019
@rhs
Merge pull request #154 from datawire/lukeshu/rhs/k8s-args/kubeapply
8ba1e6f 
k8s-args: Part 2A: Add {{image}} function to kubeapply
kflynn pushed a commit that referenced this issue Oct 19, 2019
@rhs
Merge pull request #154 from datawire/lukeshu/rhs/k8s-args/kubeapply
7aa3496 
k8s-args: Part 2A: Add {{image}} function to kubeapply
iNoahNothing pushed a commit that referenced this issue Dec 18, 2019
@khussey
Merge pull request #154 from datawire/getting-started-fix
bad39ac 
fixed link, updated image
acookin pushed a commit that referenced this issue Mar 10, 2021
@knguyen0125
fix: update knative clustterrole (#154)
583564b
anilhbtiit pushed a commit to anilhbtiit/envoyClone that referenced this issue May 27, 2024
Do not overwrite the Host header when talking to the extauth service (f…
b7ce768 
…ixes emissary-ingress/emissary#154)

Signed-off-by: Flynn <flynn@datawire.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plombardi89 @kflynn