Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support envoy headers_to_add for AuthService objects #1764

Closed
travisghansen opened this issue Aug 18, 2019 · 15 comments
Closed

support envoy headers_to_add for AuthService objects #1764

travisghansen opened this issue Aug 18, 2019 · 15 comments
Labels
t:feature New feature or enhancement request
Milestone

Comments

@travisghansen
Copy link

Please describe your use case / problem.
I would like to be able to inject headers that can be consumed by the auth service but not sent by the client.

Describe the solution you'd like
Envoy supports a headers_to_add parameter that seems to be missing or not mapped by ambassador. Note that this is separate from the allowed_headers option that appears to coincide with the AuthService option allowed_request_headers.

https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/filter/http/ext_authz/v2/ext_authz.proto#external-authorization

@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Oct 17, 2019
@travisghansen
Copy link
Author

Still valid.

@stale stale bot removed the stale Issue is stale and will be closed label Oct 17, 2019
@stale
Copy link

stale bot commented Dec 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Dec 16, 2019
@travisghansen
Copy link
Author

Yeah, still valid.

@stale stale bot removed the stale Issue is stale and will be closed label Dec 16, 2019
@stale
Copy link

stale bot commented Feb 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Feb 14, 2020
@travisghansen
Copy link
Author

Valid.

@stale stale bot removed the stale Issue is stale and will be closed label Feb 14, 2020
@stale
Copy link

stale bot commented Apr 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Apr 15, 2020
@travisghansen
Copy link
Author

sigh..

@stale stale bot removed the stale Issue is stale and will be closed label Apr 15, 2020
@stale
Copy link

stale bot commented Jun 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Jun 14, 2020
@travisghansen
Copy link
Author

Ugh.

@stale stale bot removed the stale Issue is stale and will be closed label Jun 14, 2020
@stale
Copy link

stale bot commented Aug 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Aug 13, 2020
@travisghansen
Copy link
Author

Ugh.

@stale stale bot removed the stale Issue is stale and will be closed label Aug 13, 2020
@kflynn
Copy link
Member

kflynn commented Aug 13, 2020

Huh, my apologies for losing this bug! Community member @jasonewang actually added the add_auth_headers element to the AuthService for 1.6.0; does that do what you need?

Thanks! and sorry, again, for not updating this issue when that feature went in.

@khussey khussey added the t:feature New feature or enhancement request label Aug 13, 2020
@travisghansen
Copy link
Author

Does it map to the headers_to_add attribute? If so we should be good.

@kflynn
Copy link
Member

kflynn commented Aug 14, 2020

Yup, it does. 🙂 I'll go ahead and close this -- if it doesn't work out for you, please reopen!

@kflynn kflynn closed this as completed Aug 14, 2020
@khussey khussey added this to the 2020 Cycle 4 milestone Aug 14, 2020
kflynn pushed a commit that referenced this issue Aug 24, 2020
`make generate` improvements; including go-mkopensource fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants