Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] upgrade-envoy-and-go #5687

Closed
wants to merge 6 commits into from
Closed

Conversation

AliceProxy
Copy link
Member

Description

A few sentences describing the overall goals of the pull request's commits.

Related Issues

List related issues.

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Lance Austin and others added 5 commits May 15, 2024 21:12
Bumps to Envoy 1.28.0 and regenerates compiled protos.

steps:
1. update envoy.mk to v1.28 commit with custom commits
2. ran `make update-base`

Signed-off-by: Lance Austin <laustin@dataiwre.io>
Updates go-control-plane to the latest version sync'd and tested against
Envoy 1.28.

Signed-off-by: Lance Austin <laustin@dataiwre.io>
Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Signed-off-by: Alice Wasko <alicewasko@datawire.io>
Signed-off-by: Alice Wasko <alicewasko@datawire.io>
@AliceProxy AliceProxy force-pushed the alicewasko/upgrade-envoy-go branch from 9765afb to 73a7f57 Compare May 17, 2024 01:35
Signed-off-by: Alice Wasko <alicewasko@datawire.io>
@AliceProxy AliceProxy closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant