Add Unit Test for Executable #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a simple unit test for the executable.
shaardie
requested changes
Dec 6, 2019
There was a problem hiding this comment.
Unfortunately this brakes running the tests with
$ python setup.py test
running test
running egg_info
writing sentinel5dl.egg-info/PKG-INFO
writing dependency_links to sentinel5dl.egg-info/dependency_links.txt
writing entry points to sentinel5dl.egg-info/entry_points.txt
writing requirements to sentinel5dl.egg-info/requires.txt
writing top-level names to sentinel5dl.egg-info/top_level.txt
reading manifest file 'sentinel5dl.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'sentinel5dl.egg-info/SOURCES.txt'
running build_ext
test (tests.__main__.TestExecutable)
Test search and download. ... usage: setup.py [-h] [--polygon POLYGON] [--product PRODUCT] [--level {L1B,L2}] [--begin-ts BEGIN_TS] [--end-ts END_TS] [--use-certifi]
setup.py: error: unrecognized arguments: test
ERROR
test (tests.__main__.TestSentinel5dl)
Test search and download. ... ok
======================================================================
ERROR: test (tests.__main__.TestExecutable)
Test search and download.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/sven/devel/emission-api/sentinel5dl/tests/__main__.py", line 106, in test
executable.main()
File "/home/sven/devel/emission-api/sentinel5dl/sentinel5dl/__main__.py", line 153, in main
args = parser.parse_args()
File "/usr/lib/python3.8/argparse.py", line 1771, in parse_args
self.error(msg % ' '.join(argv))
File "/usr/lib/python3.8/argparse.py", line 2520, in error
self.exit(2, _('%(prog)s: error: %(message)s\n') % args)
File "/usr/lib/python3.8/argparse.py", line 2507, in exit
_sys.exit(status)
SystemExit: 2
----------------------------------------------------------------------
Ran 2 tests in 0.005s
FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=2 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=2 errors=1 failures=0>
`argparse` is trying to parse the command line arguments while testing the binary. This patch simply clears `sys.argv` to circumvent that.
shaardie
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a simple unit test for the executable.