Time Specification #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
force-pushed
the
time-parsing
branch
from
4ad104c
to
565696a
Compare
The Copernicus API is very picky when it comes to date/time formats, accepting only a subset of ISO-8601 time strings. To make working with the API easier and less error-prone, this patch makes sentinel5dl accept datetime objects for time specification, automatically converting them into the required string representation.
With try catch we do not explicitely rule object out which are not `datetime.datetime` objects.
shaardie
force-pushed
the
time-parsing
branch
from
565696a
to
274e5d2
Compare
shaardie
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Copernicus API is very picky when it comes to date/time formats,
accepting only a subset of ISO-8601 time strings. To make working with
the API easier and less error-prone, this patch makes sentinel5dl accept
datetime objects for time specification, automatically converting them
into the required string representation.