Remove Default Polygon #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the default polygon since with its existence, it's nearly impossible to specify no polygon/the world as download option.
lkiesow
force-pushed
the
rm-default-polygon
branch
from
fbd0e70
to
9539663
Compare
|
schouldn't just calling search() work since polygon is the the whole world and for all the other arguments we got default values? if i try this out search will work but download doens't create an nc file |
|
but anyway your pr works |
|
This just changes the default for the binary, not the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the default polygon since with its existence, it's
nearly impossible to specify no polygon/the world as download option.