Internal Log Formatter #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkiesow
force-pushed
the
logger-format
branch
from
ab45b08
to
21ff457
Compare
This patch switches to the internal log formatter which will format strings only if necessary instead of formatting the strings first ans always passing the formatted strings to the logger.
lkiesow
force-pushed
the
logger-format
branch
from
21ff457
to
d80bf89
Compare
|
Fixed conflict. |
shaardie
approved these changes
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch switches to the internal log formatter which will format
strings only if necessary instead of formatting the strings first ans
always passing the formatted strings to the logger.