Fix Renaming Temporary Files #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the renaming of temporary files on Windows which fails with the error that a process still has an open file handler on these files. The process is sentinal5dl itself which did not close the file yet. This fixes emissions-api#70 This fixes emissions-api#71
lkiesow
added a commit
that referenced
this pull request
Oct 2, 2021
List of important changes. For a comprehensive list, take a look at the commit history. - [Additional Executable Tests ](#62) - [Introduce Bandit Security Linter ](#65) - [Fix return values from retried HTTP requests ](#76) - [Fix some error messages ](#77) - [Fix renaming temporary files causing errors on Windows ](#78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the renaming of temporary files on Windows which fails
with the error that a process still has an open file handler on these
files. The process is sentinal5dl itself which did not close the file
yet.
This fixes #70
This fixes #71