Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/network/http: fix dropped test errors #412

Merged
merged 1 commit into from
Sep 28, 2023
Merged

internal/network/http: fix dropped test errors #412

merged 1 commit into from
Sep 28, 2023

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 28, 2023

This fixes two dropped err variables in the tests for the internal/network/http package.

Florimond
Florimond approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Florimond
Copy link
Member

Florimond commented Sep 28, 2023 •
edited

EDIT: forget it, it was just a stupid random number falling unexpectedly beyond an acceptable deviation. Just re-ran the test, it's fine.

While the changes themselves still LGTM, it seems some tests are not passing anymore. But at the same time, I don't see how these changes could suddlenly break them.
Would you have a look @alrs ? This code is probably fresher in your mind than in mine! Otherwise I'll give it a look this w-e...

Thank you for your contribution!

@coveralls
Copy link

Coverage Status

coverage: 93.109%. remained the same when pulling ddc5747 on alrs:http-test-errs into bb61442 on emitter-io:master.

@Florimond Florimond merged commit 30adcd2 into emitter-io:master Sep 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florimond Florimond Florimond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alrs @Florimond @coveralls