Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added significantly more tests #47

Merged
merged 8 commits into from
Nov 16, 2017
Merged

added significantly more tests #47

merged 8 commits into from
Nov 16, 2017

Conversation

kelindar
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.09%) to 74.464% when pulling f62c673 on feat-ws into 6b57bb7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.1%) to 76.479% when pulling 204fa11 on feat-ws into 6b57bb7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.3%) to 78.64% when pulling 1037253 on feat-ws into 6b57bb7 on master.

@kelindar kelindar changed the title made websocket package more testable added significantly more tests Nov 16, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+8.07%) to 80.446% when pulling d300ffb on feat-ws into 6b57bb7 on master.

Florimond
Florimond approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Florimond
Florimond approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+8.8%) to 81.179% when pulling 51775d9 on feat-ws into 6b57bb7 on master.

Florimond
Florimond approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelindar kelindar merged commit 86ef0ba into master Nov 16, 2017
@kelindar kelindar deleted the feat-ws branch November 16, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florimond Florimond Florimond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelindar @coveralls @Florimond