Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolving the seed hostname on join #51

Merged
merged 1 commit into from
Nov 18, 2017
Merged

resolving the seed hostname on join #51

merged 1 commit into from
Nov 18, 2017

Conversation

kelindar
Copy link
Contributor

@kelindar kelindar commented Nov 18, 2017 •
edited

With this, the broker will resolve a seed domain name and attempt to join all the nodes registered (see #18). This should make simultaneous cluster restarts more robust.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 84.697% when pulling e9f69d6 on feat-resolve into b7a4cfe on master.

Florimond
Florimond approved these changes Nov 18, 2017
View reviewed changes
Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelindar kelindar merged commit d3b4648 into master Nov 18, 2017
@kelindar kelindar deleted the feat-resolve branch November 18, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florimond Florimond Florimond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kelindar @coveralls @Florimond