Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to graph visualization in tikz + dot! #26

Closed
emjun opened this issue Aug 11, 2021 · 1 comment
Closed

Fixes to graph visualization in tikz + dot! #26

emjun opened this issue Aug 11, 2021 · 1 comment
Assignees
@audreyseo

Comments

@emjun
Copy link
Owner

emjun commented Aug 11, 2021

  • causes and associates edges should be the same style (solid) and different from has (dotted), nests (dashed)
  • dependent variables should be filled in with "light-ish" grey (i.e., grey!30) -->
    def get_causes_associates_tikz_graph(self) --> def get_causes_associates_tikz_graph(self, dv: AbstractVariable)
@emjun emjun changed the title Fixes to graph visualization in tikz Fixes to graph visualization in tikz + dot! Aug 11, 2021
@emjun
Copy link
Owner Author

emjun commented Aug 11, 2021

Afterwards, PR to merge into main and then add missing data types (e.g., SetUp), update function names (e.g., moderatesss), etc. based on new API

audreyseo added a commit that referenced this issue Aug 13, 2021
@audreyseo
Add support for dependent variables in vis (#26)
b4041a3 
This should also fix styles.

I added some helpful checks for whether intermediate directories exist
when you try to write a graph to a path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@audreyseo audreyseo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@audreyseo @emjun