Vobsub: allow parsing demuxed data streams #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `needed` length was not available in all cases which made it useless in some situations in chunk mode. This commit attempts to guestimate the `needed` length so that the next chunk is always large enough for the next iteration to at least give a new `needed` length which will allow progressing in the stream.
In a framework such as GStreamer, the `vobsub` decoder will be inserted in a pipeline after elements taking care of demuxing the Mpeg 2 stream. In such a situation, the PES packets are already parsed. Only the subtitle data is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a framework such as GStreamer, the
vobsubdecoder will be inserted ina pipeline after elements taking care of demuxing the Mpeg 2 stream. In
such a situation, the PES packets are already parsed. Only the subtitle data
is available.
This PR introduces the data mode in
SubtitlesFromChunkswhich uses the sameinterface as the packet mode. The file
fixtures/example_data.subis a demuxedversion of
fixtures/example.sub.Notes: