Skip to content

Commit

Permalink
don't hard code -larrow and -lparquet
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffwong-nflx committed Jan 4, 2019
1 parent 8ccaa51 commit 1df3026
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions r/configure
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ PKG_RPM_NAME="arrow"
PKG_CSW_NAME="arrow"
PKG_BREW_NAME="apache-arrow"
PKG_TEST_HEADER="<arrow/api.h>"
PKG_LIBS="-larrow"
PKG_LIBS="-larrow -lparquet"

# Use pkg-config if available
pkg-config --version >/dev/null 2>&1
Expand All @@ -49,8 +49,7 @@ if [ "$INCLUDE_DIR" ] || [ "$LIB_DIR" ]; then
elif [ "$PKGCONFIG_CFLAGS" ] || [ "$PKGCONFIG_LIBS" ]; then
echo "Found pkg-config cflags and libs!"
PKG_CFLAGS=${PKGCONFIG_CFLAGS}
#PKG_LIBS=${PKGCONFIG_LIBS}
PKG_LIBS="-larrow -lparquet" # hard coded! what is the right way to do this?
PKG_LIBS=${PKGCONFIG_LIBS}
elif [[ "$OSTYPE" == "darwin"* ]]; then
if [ "$(command -v brew)" ]; then
BREWDIR=$(brew --prefix)
Expand Down

0 comments on commit 1df3026

Please sign in to comment.