-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow styling of nodes within phylogram.plot()
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(untested!)
Increment version number so external packages can check whether functionality available
re. lty.v length error in phytools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of settings where it is useful to be able to style the vertical lines associated with polytomies (example).
I'm hoping that it would be possible to extend the functionality of
plot.phylo()
to support this.This PR adds
node.color
,node.width
andnode.lty
parameters that allow nodes to be styled separately from their pendant edges. If these parameters are unspecified, the existing behaviour ofplot.phylo()
remains unchanged.If
node.color
(etc.) parameters are specified andedge.color
is unspecified, then edge colours will be inferred based on the child node.Example output:
I've checked a few basic test cases – but is there a standard set of test plots that I should verify reproduced correctly with the new code?
I have not attempted to extended this functionality to plotting types other than "phylogram".